Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require create_archive.py to take a version number #487

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Do not require create_archive.py to take a version number #487

merged 1 commit into from
Oct 27, 2023

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 26, 2023 •
edited
Loading

Closes #486

@mulkieran mulkieran self-assigned this Oct 26, 2023
@mulkieran mulkieran force-pushed the issue_ci_486 branch 2 times, most recently from 8e0d5b8 to faadf4d Compare October 26, 2023 16:35
@mulkieran
Copy link
Member Author

Need to edit Requires for stratisd as well.

@mulkieran
Copy link
Member Author

mulkieran commented Oct 26, 2023 •
edited
Loading

It is the same as the MINIMUM_STRATISD_VERSION in the source code. There is also the MAXIMUM_STRATISD_VERSION, which is the upper bound.

We decided to skip this. Very difficult to get this correct with pre-release versions.

@mulkieran mulkieran marked this pull request as ready for review October 26, 2023 19:31
@mulkieran mulkieran merged commit 05acc0b into stratis-storage:master Oct 27, 2023
5 checks passed
@mulkieran mulkieran deleted the issue_ci_486 branch October 27, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgurney-rh bgurney-rh bgurney-rh approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement to create_archive.py
2 participants
@mulkieran @bgurney-rh